Skip to content

Add pygrep-hooks in .pre-commit-config.yaml to catch common mistakes in .rst files - #899

Merged
leofang merged 6 commits into
NVIDIA:mainfrom
rwgk:pre-commit-pygrep-hooks
Aug 25, 2025
Merged

Add pygrep-hooks in .pre-commit-config.yaml to catch common mistakes in .rst files#899
leofang merged 6 commits into
NVIDIA:mainfrom
rwgk:pre-commit-pygrep-hooks

Conversation

@rwgk

@rwgk rwgk commented Aug 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Copy pygrep-hooks from pybind11/.pre-commit-config.yaml and clean up a few files (all trivial).

New pre-commit.ci - pr output:

ruff (legacy alias)......................................................Passed
ruff format..............................................................Passed
Check SPDX Headers.......................................................Passed
Prevent markdown files in docs/source directories........................Passed
rst ``code`` is two backticks............................................Passed
rst directives end with two colons.......................................Passed
rst ``inline code`` next to normal text..................................Passed
bandit..................................................................Skipped
mypy-pathfinder..........................................................Passed

@copy-pr-bot

copy-pr-bot Bot commented Aug 25, 2025

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@rwgk
rwgk marked this pull request as ready for review August 25, 2025 19:10
@copy-pr-bot

copy-pr-bot Bot commented Aug 25, 2025

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@rwgk

rwgk commented Aug 25, 2025

Copy link
Copy Markdown
Contributor Author

@leofang Should we skip the full CI for this PR? It only changes these files:

$ git diff main --name-only
.pre-commit-config.yaml
cuda_core/DESCRIPTION.rst
cuda_core/docs/source/interoperability.rst
cuda_core/docs/source/release/0.1.0-notes.rst
cuda_core/docs/source/release/0.1.1-notes.rst
cuda_core/docs/source/release/0.3.0-notes.rst
cuda_core/docs/source/release/0.X.Y-notes.rst
cuda_python/DESCRIPTION.rst

leofang
leofang approved these changes Aug 25, 2025
View reviewed changes

@leofang leofang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Ralf!

Comment thread cuda_core/docs/source/interoperability.rst
(currently version 0) as follows: For any Python objects that are meant to be interpreted
as a stream, they should add a ``__cuda_stream__`` *method* that returns a 2-tuple: The
version number (``0``) and the address of ``cudaStream_t`` (both as Python `int`):
version number (``0``) and the address of ``cudaStream_t`` (both as Python ``int``):

@leofang leofang Aug 25, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm... interesting that this is not linking to the docs for Python int anymore, alright let's fix it this way

Comment thread cuda_core/docs/source/release/0.3.0-notes.rst
- :class:`~_module.Kernel` adds :attr:`~_module.Kernel.num_arguments` and :attr:`~_module.Kernel.arguments_info` for introspection of kernel arguments. (#612)
- Add pythonic access to kernel occupancy calculation functions via :attr:`Kernel.occupancy`. (#648)
- Support launching cooperative kernels by setting :attr:`LaunchConfig.cooperative_launch` to `True`.
- Support launching cooperative kernels by setting :attr:`LaunchConfig.cooperative_launch` to ``True``.

@leofang leofang Aug 25, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@leofang
leofang merged commit b003a92 into NVIDIA:main Aug 25, 2025
1 check passed
@leofang leofang added documentation Improvements or additions to documentation enhancement Any code-related improvements P1 Medium priority - Should do CI/CD CI/CD infrastructure labels Aug 25, 2025
@leofang leofang added this to the cuda.core beta 7 milestone Aug 25, 2025
@github-actions

github-actions Bot commented Aug 25, 2025

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leofang leofang leofang approved these changes

Assignees

@rwgk rwgk

Labels

CI/CD CI/CD infrastructure documentation Improvements or additions to documentation enhancement Any code-related improvements P1 Medium priority - Should do

Projects

None yet

Milestone

cuda.core beta 7

Development

Successfully merging this pull request may close these issues.

2 participants

@rwgk @leofang